Messages in this thread | | | Date | Wed, 8 Nov 2017 22:15:25 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH] x86/mm: Unbreak modules that rely on external PAGE_KERNEL availability |
| |
On Wed, Nov 08, 2017 at 01:09:29PM -0800, Linus Torvalds wrote: > Generally we should export _functionality_, not data.
Right, AFAIRC, the main reason for this being an export was because if we hid it in a function, you'd have all those function calls as part of the _PAGE_* macros and that's just crap.
And then having an accessor too for the mask which we export anyway is kinda silly.
But maybe there's a different, nicer solution which we missed...
-- Regards/Gruss, Boris.
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) --
| |