lkml.org 
[lkml]   [2017]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] ARM: sun8i: a83t: add dwmac-sun8i ethernet driver
On Wed, Nov 08, 2017 at 02:27:21PM +0800, Chen-Yu Tsai wrote:
> On Wed, Nov 8, 2017 at 4:13 AM, Corentin Labbe
> <clabbe.montjoie@gmail.com> wrote:
> > The dwmac-sun8i is an ethernet MAC hardware that support 10/100/1000 speed.
> > This patch enable the dwmac-sun8i on the Allwinner a83t SoC Device-tree.
>
> The subject should say "add .... device node", not driver.
>
> >
> > Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> > Reviewed-by: Chen-Yu Tsai <wens@csie.org>
> > ---
> > arch/arm/boot/dts/sun8i-a83t.dtsi | 29 +++++++++++++++++++++++++++++
> > 1 file changed, 29 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi
> > index 19acae1b4089..68e5135410ec 100644
> > --- a/arch/arm/boot/dts/sun8i-a83t.dtsi
> > +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi
> > @@ -336,6 +336,14 @@
> > #interrupt-cells = <3>;
> > #gpio-cells = <3>;
> >
> > + emac_rgmii_pins: emac-rgmii-pins {
> > + pins = "PD2", "PD3", "PD4", "PD5", "PD6", "PD7",
> > + "PD11", "PD12", "PD13", "PD14", "PD18",
> > + "PD19", "PD21", "PD22", "PD23";
> > + function = "gmac";
> > + drive-strength = <40>;
> > + };
> > +
>
> You should mention this change in your commit log.
>
> ChenYu
>

Ok I will do it

Thanks
Regards

\
 
 \ /
  Last update: 2017-11-08 21:15    [W:0.057 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site