Messages in this thread | | | From | Eric Anholt <> | Subject | Re: [PATCH v2 06/12] hwrng: bcm2835-rng: Rework interrupt masking | Date | Wed, 08 Nov 2017 10:26:48 -0800 |
| |
Florian Fainelli <f.fainelli@gmail.com> writes:
> The interrupt masking done for Northstart Plus and Northstar (BCM5301X) > is moved from being a function pointer mapped to of_device_id::data into > a proper part of the hwrng::init callback. While at it, we also make the > of_data be a proper structure indicating the platform specifics, since > the day we need to add a second type of platform information, we would > have to do that anyway.
I still think we should just unconditionally mask off the interrupt regardless of platform if we're not going to use it in the driver and some platforms need it. Looks like a fine refactor, though:
Reviewed-by: Eric Anholt <eric@anholt.net> [unhandled content-type:application/pgp-signature] | |