Messages in this thread | | | From | Haiyang Zhang <> | Subject | RE: [Revised PATCH v2] hv: kvp: Avoid reading past allocated blocks from KVP file | Date | Wed, 8 Nov 2017 14:21:56 +0000 |
| |
> -----Original Message----- > From: Long Li [mailto:longli@exchange.microsoft.com] > Sent: Wednesday, November 1, 2017 2:45 PM > To: KY Srinivasan <kys@microsoft.com>; Haiyang Zhang > <haiyangz@microsoft.com>; Stephen Hemminger > <sthemmin@microsoft.com>; devel@linuxdriverproject.org; linux- > kernel@vger.kernel.org > Cc: Paul Meyer <Paul.Meyer@microsoft.com>; Long Li > <longli@microsoft.com> > Subject: [Revised PATCH v2] hv: kvp: Avoid reading past allocated blocks > from KVP file > > [This sender failed our fraud detection checks and may not be who they > appear to be. Learn about spoofing at http://aka.ms/LearnAboutSpoofing] > > From: Paul Meyer <Paul.Meyer@microsoft.com> > > While reading in more than one block (50) of KVP records, the allocation > goes per block, but the reads used the total number of allocated records > (without resetting the pointer/stream). This causes the records buffer to > overrun when the refresh reads more than one block over the previous > capacity (e.g. reading more than 100 KVP records whereas the in-memory > database was empty before). > > Fix this by reading the correct number of KVP records from file each time. > > Changes since v1: > 1. Properly wrapped comment texts. > 2. Added the 2nd Signed-off-by. > > Signed-off-by: Paul Meyer <Paul.Meyer@microsoft.com> > Signed-off-by: Long Li <longli@microsoft.com>
Reviewed-by: Haiyang Zhang <haiyangz@microsoft.com>
| |