lkml.org 
[lkml]   [2017]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 1/2] ASoC: Intel: improve DMADEVICES dependency
On Wed, Nov 8, 2017 at 3:09 PM, Vinod Koul <vinod.koul@intel.com> wrote:
> On Wed, Nov 08, 2017 at 02:03:19PM +0100, Arnd Bergmann wrote:
>> As pointed out by Pierre-Louis Bossart, the depndency I added
>
> /s/depndency/dependency

Mark, can you fix that up when applying, or should I resend?

>> diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig
>> index e18118209b75..bb8be10b8437 100644
>> --- a/sound/soc/intel/Kconfig
>> +++ b/sound/soc/intel/Kconfig
>> @@ -32,19 +32,20 @@ config SND_SOC_ACPI_INTEL_MATCH
>> config SND_SOC_INTEL_SST_TOPLEVEL
>> tristate "Intel ASoC SST drivers"
>> depends on X86 || COMPILE_TEST
>> - depends on DMADEVICES
>> select SND_SOC_INTEL_MACH
>> select SND_SOC_INTEL_COMMON
>>
>> config SND_SOC_INTEL_HASWELL
>> tristate "Intel ASoC SST driver for Haswell/Broadwell"
>> depends on SND_SOC_INTEL_SST_TOPLEVEL && SND_DMA_SGBUF
>> + depends on DMADEVICES
>> select SND_SOC_INTEL_SST
>> select SND_SOC_INTEL_SST_FIRMWARE
>>

>> --- a/sound/soc/intel/boards/Kconfig
>> +++ b/sound/soc/intel/boards/Kconfig
>> @@ -19,7 +19,6 @@ config SND_SOC_INTEL_HASWELL_MACH
>> tristate "ASoC Audio DSP support for Intel Haswell Lynxpoint"
>> depends on SND_SOC_INTEL_MACH
>> depends on X86_INTEL_LPSS && I2C && I2C_DESIGNWARE_PLATFORM
>> - depends on DMADEVICES
>
> Per Liam this seems to be required for Haswell
>
>
>> depends on SND_SOC_INTEL_HASWELL

Correct, I just moved it to a different place above, we now get it through
the SND_SOC_INTEL_HASWELL dependency.

Arnd

\
 
 \ /
  Last update: 2017-11-08 21:12    [W:0.369 / U:0.332 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site