lkml.org 
[lkml]   [2017]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH net-next] net: dsa: lan9303: Fix lan9303_alr_del_port()
    Date
    Fix embarrassing bug in lan9303_alr_del_port(): Instead of zeroing
    entr->mac_addr, I destroyed the next cache entry. Affected .port_fdb_del and
    .port_mdb_del.

    Fixes: 0620427ea0d6 ("net: dsa: lan9303: Add fdb/mdb manipulation")
    Signed-off-by: Egil Hjelmeland <privat@egil-hjelmeland.no>
    ---
    drivers/net/dsa/lan9303-core.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/dsa/lan9303-core.c b/drivers/net/dsa/lan9303-core.c
    index 320651a57c6f..c0910aebc037 100644
    --- a/drivers/net/dsa/lan9303-core.c
    +++ b/drivers/net/dsa/lan9303-core.c
    @@ -702,7 +702,7 @@ static int lan9303_alr_del_port(struct lan9303 *chip, const u8 *mac, int port)

    entr->port_map &= ~BIT(port);
    if (entr->port_map == 0) /* zero means its free again */
    - eth_zero_addr(&entr->port_map);
    + eth_zero_addr(entr->mac_addr);
    lan9303_alr_set_entry(chip, mac, entr->port_map, entr->stp_override);

    return 0;
    --
    2.11.0
    \
     
     \ /
      Last update: 2017-11-08 21:11    [W:2.800 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site