Messages in this thread | | | From | Linus Walleij <> | Date | Wed, 8 Nov 2017 10:28:44 +0100 | Subject | Re: [PATCH V13 07/10] mmc: block: blk-mq: Add support for direct completion |
| |
On Fri, Nov 3, 2017 at 2:20 PM, Adrian Hunter <adrian.hunter@intel.com> wrote:
> For blk-mq, add support for completing requests directly in the ->done > callback. That means that error handling and urgent background operations > must be handled by recovery_work in that case. > > Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
I tried enabling this on my MMC host (mmci) but I got weird DMA error messages when I did.
I guess this has not been tested on a non-DMA-coherent system?
I think I might be seeing this because the .pre and .post callbacks need to be strictly sequenced, and this is maybe not taken into account here? Isn't there as risk that the .post callback of the next request is called before the .post callback of the previous request has returned for example?
Yours, Linus Walleij
| |