lkml.org 
[lkml]   [2017]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: fsl-dpaa2: Fix multiple assignments should be avoided
On Tue, Nov 07, 2017 at 07:45:03PM -0500, Joshua Abraham wrote:
> This patch fixes the checkpatch.pl warning:
> "CHECK: multiple assignments should be avoided"
>
> Signed-off-by: Joshua Abraham <j.abraham1776@gmail.com>
> ---
> drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c b/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c
> index 0d8ed002adcb..384218946108 100644
> --- a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c
> +++ b/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c
> @@ -1661,7 +1661,8 @@ static void set_fq_affinity(struct dpaa2_eth_priv *priv)
> * This may well change at runtime, either through irqbalance or
> * through direct user intervention.
> */
> - rx_cpu = txc_cpu = cpumask_first(&priv->dpio_cpumask);
> + rx_cpu = cpumask_first(&priv->dpio_cpumask);
> + txc_cpu = rx_cpu;

The original code here makes much more sense, doesn't it?

Sometimes checkpatch is wrong :)

thanks,

greg k-h

\
 
 \ /
  Last update: 2017-11-08 21:11    [W:0.077 / U:4.700 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site