lkml.org 
[lkml]   [2017]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] kallsyms: don't leak address when printing symbol
On (11/08/17 22:35), Steven Rostedt wrote:
> On Thu, 9 Nov 2017 12:50:29 +1100
> "Tobin C. Harding" <me@tobin.cc> wrote:
>
> > Currently if a pointer is printed using %p[ssB] and the symbol is not
> > found (kallsyms_lookup() fails) then we print the actual address. This
> > leaks kernel addresses. We should instead print something _safe_.
> >
> > Print "<no-symbol>" instead of kernel address.
>
> Ug, ftrace requires this to work as is, as it uses it to print some
> addresses that may or may not be a symbol.
>
> If anything, can this return a success or failure if it were to find a
> symbol or not, and then something like ftrace could decide to use %x if
> it does not.
>
> And yes, ftrace leaks kernel addresses all over the place, that's just
> the nature of tracing the kernel.
>

agree, I kinda suspect that that "0x%lx" sometimes can be useful.
at least one can tell if the frame is from modules or kernel, and
objdump it may be.

-ss

\
 
 \ /
  Last update: 2017-11-09 05:24    [W:0.083 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site