lkml.org 
[lkml]   [2017]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
SubjectRe: linux-next: build warning after merge of the overlayfs tree
Date
On Thursday, November 9, 2017 4:03:06 AM IST Stephen Rothwell wrote:
> Hi Miklos,
>
> After merging the overlayfs tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
>
> fs/overlayfs/super.c: In function 'ovl_fill_super':
> fs/overlayfs/super.c:1070:25: warning: 'numlower' may be used uninitialized in this function [-Wmaybe-uninitialized]
> unsigned int stacklen, numlower, i;
> ^
> fs/overlayfs/super.c:1069:15: warning: 'stack' may be used uninitialized in this function [-Wmaybe-uninitialized]
> struct path *stack;
> ^
>
>

The following trivial patch resolves the warnings,

diff --git a/fs/overlayfs/super.c b/fs/overlayfs/super.c
index fd11c05..602e686 100644
--- a/fs/overlayfs/super.c
+++ b/fs/overlayfs/super.c
@@ -1066,8 +1066,8 @@ static struct ovl_entry *ovl_get_lowerstack(struct super_block *sb,
{
int err;
char *lowertmp, *lower;
- struct path *stack;
- unsigned int stacklen, numlower, i;
+ struct path *stack = NULL;
+ unsigned int stacklen, numlower = 0, i;
bool remote = false;
struct ovl_entry *oe;

--
chandan
\
 
 \ /
  Last update: 2017-11-09 04:59    [W:0.051 / U:9.792 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site