Messages in this thread | | | Date | Tue, 7 Nov 2017 20:43:01 +0100 | From | "Luis R. Rodriguez" <> | Subject | Re: [PATCH] firmware: raspberrypi: Eliminate use of time_to_tm |
| |
On Sun, Nov 05, 2017 at 03:21:46AM +0530, Himanshu Jha wrote: > time_to_tm function is deprecated due to y2038 problem, therefore use > time64_to_tm instead.
Use ./scripts/get_maintainer.pl foo.patch and resend with the respective folks addressed to as needed (To or Cc as indicated by the script).
Your commit log should reference why *time_to_tm()* is now deprecated in favor for time64_to_tm() to make maintainer's lives easier so that their lookup is faster.
Resend with these details. Likewise for the other patches for which you failed to do any of this for.
Luis
> Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com> > --- > drivers/firmware/raspberrypi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/firmware/raspberrypi.c b/drivers/firmware/raspberrypi.c > index dd506cd..aa4c797 100644 > --- a/drivers/firmware/raspberrypi.c > +++ b/drivers/firmware/raspberrypi.c > @@ -166,7 +166,7 @@ EXPORT_SYMBOL_GPL(rpi_firmware_property); > static void > rpi_firmware_print_firmware_revision(struct rpi_firmware *fw) > { > - u32 packet; > + time64_t packet; > int ret = rpi_firmware_property(fw, > RPI_FIRMWARE_GET_FIRMWARE_REVISION, > &packet, sizeof(packet)); > @@ -174,7 +174,7 @@ rpi_firmware_print_firmware_revision(struct rpi_firmware *fw) > if (ret == 0) { > struct tm tm; > > - time_to_tm(packet, 0, &tm); > + time64_to_tm(packet, 0, &tm); > > dev_info(fw->cl.dev, > "Attached to firmware from %04ld-%02d-%02d %02d:%02d\n", > -- > 2.7.4 > >
-- Luis Rodriguez, SUSE LINUX GmbH Maxfeldstrasse 5; D-90409 Nuernberg
| |