Messages in this thread Patch in this message | | | From | Alexander Sverdlin <> | Subject | Re: [PATCH] lockdep: Add missing declaration of 'pr_cont()' | Date | Tue, 07 Nov 2017 17:10:07 +0100 |
| |
Hello!
On Tue Nov 7 03:24:20 2017 Mengting Zhang <zhangmengting@huawei.com> wrote: > An annoying compile warning due to missing declaration is shown below: > In file included from lockdep.c:27:0: > ../../../kernel/locking/lockdep.c: In function > 'print_unlock_imbalance_bug' : ../../../kernel/locking/lockdep.c:3544:2: > warning: implicit declaration of function 'pr_cont' > [-Wimplicit-function-declaration] pr_cont(") at:\n"); ^ > Adding the declaration of 'pr_cont' fixes the problem. > > Signed-off-by: Mengting Zhang <zhangmengting@huawei.com>
Your commit brought my attention to the fact that commit 681fbec881 brought a regression, rendering 20fb654ae fix ineffective.
But this is not related to your change, which I believe is correct: Reviewed-by: Alexander Sverdlin <alexander.sverdlin@gmail.com>
> --- > tools/include/linux/lockdep.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/include/linux/lockdep.h > b/tools/include/linux/lockdep.h index 8da3e8e..ae716ad 100644 > --- a/tools/include/linux/lockdep.h > +++ b/tools/include/linux/lockdep.h > @@ -47,6 +47,7 @@ static inline int debug_locks_off(void) > #define printk(...) dprintf(STDOUT_FILENO, __VA_ARGS__) > #define pr_err(format, ...) fprintf (stderr, format, ## __VA_ARGS__) > #define pr_warn pr_err > +#define pr_cont pr_err > > #define list_del_rcu list_del > > -- > 1.7.12.4 >
| |