lkml.org 
[lkml]   [2017]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectNAK: [PATCH] usb: gadget: pxa27x: Remove redundant assignment to is_short
From
Date
On 07/11/17 14:31, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Variable is set to zero but this value is never read as it is
> overwritten with a new value later on, hence it is a redundant
> assignment and can be removed. Cleans up clang warning:
>
> drivers/usb/gadget/udc/pxa27x_udc.c:1141:2: warning: Value stored
> to 'dev' is never read
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/usb/gadget/udc/pxa27x_udc.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/usb/gadget/udc/pxa27x_udc.c b/drivers/usb/gadget/udc/pxa27x_udc.c
> index 14606f340325..e3d362cc47db 100644
> --- a/drivers/usb/gadget/udc/pxa27x_udc.c
> +++ b/drivers/usb/gadget/udc/pxa27x_udc.c
> @@ -984,8 +984,6 @@ static int write_fifo(struct pxa_ep *ep, struct pxa27x_request *req)
>
> max = ep->fifo_size;
> do {
> - is_short = 0;
> -
> udccsr = udc_ep_readl(ep, UDCCSR);
> if (udccsr & UDCCSR_PC) {
> ep_vdbg(ep, "Clearing Transmit Complete, udccsr=%x\n",
>
Ignore this, sorry. It's wrong

\
 
 \ /
  Last update: 2017-11-08 21:05    [W:0.073 / U:0.288 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site