lkml.org 
[lkml]   [2017]   [Nov]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.2 144/147] staging: bcm: add 32-bit host dependency
    3.2.95-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Arnd Bergmann <arnd@arndb.de>

    The driver uses a 32-bit variable to store a pointer, causing a couple of
    warnings:

    ../drivers/staging/bcm/CmHost.c: In function 'StoreCmControlResponseMessage':
    ../drivers/staging/bcm/CmHost.c:1503:3: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
    (struct bcm_connect_mgr_params *) ntohl(
    ^
    ../drivers/staging/bcm/CmHost.c:1546:3: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
    (struct bcm_connect_mgr_params *) ntohl(
    ^
    ../drivers/staging/bcm/CmHost.c:1564:3: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
    (struct bcm_connect_mgr_params *) ntohl(

    I fixed other warnings in an earlier commit 9f1c75ac2dba ("staging/bcm: fix most
    build warnings"), but couldn't figure out what was the intended behavior on
    64-bit machines here.

    The driver was removed in linux-3.19, commit d09e9b160fc1 ("staging: bcm: remove
    driver") which explains that it never worked on 64-bit machines. This adds
    a Kconfig dependency instead to prevent it from being built in the known
    broken configuration. This workaround applies to v2.6.37 or higher.

    Fixes: f8942e07a3db ("staging: Beeceem USB Wimax driver")
    Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    [bwh: Backported to 3.2: adjust context]
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/staging/bcm/Kconfig | 1 +
    1 file changed, 1 insertion(+)

    --- a/drivers/staging/bcm/Kconfig
    +++ b/drivers/staging/bcm/Kconfig
    @@ -1,6 +1,7 @@
    config BCM_WIMAX
    tristate "Beceem BCS200/BCS220-3 and BCSM250 wimax support"
    depends on USB && NET && EXPERIMENTAL
    + depends on !64BIT
    default N
    help
    This is an experimental driver for the Beceem WIMAX chipset used
    \
     
     \ /
      Last update: 2017-11-08 20:57    [W:4.026 / U:0.832 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site