lkml.org 
[lkml]   [2017]   [Nov]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] nvme: do not check for ns on rw path
On Sat, Nov 04, 2017 at 09:38:45AM -0600, Keith Busch wrote:
> That's not quite right. For non-PI metadata formats, we use the
> 'nop_profile', which gets the metadata buffer allocated so we can safely
> use a metadata formatted namespace. There's no in-kernel user of the
> allocated payload, but we still need the metadata buffer in order to
> use the namespace at all.

You're right. But that means we will indeed always have a matching
integrity payload here and the check should not be needed.

Are you fine with turning it into something like:

if (WARN_ON_ONCE(ns->ms && !blk_integrity_rq(req)))
return BLK_STS_IOERR;

?

\
 
 \ /
  Last update: 2017-11-06 10:29    [W:0.060 / U:3.780 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site