lkml.org 
[lkml]   [2017]   [Nov]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 238/294] mvsas: fix misleading indentation
    3.16.50-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Luis de Bethencourt <luisbg@osg.samsung.com>

    commit 7789cd39274c51bf475411fe22a8ee7255082809 upstream.

    Fix a smatch warning:
    drivers/scsi/mvsas/mv_sas.c:740 mvs_task_prep() warn: curly braces intended?

    The code is correct, the indention is misleading. When the device is not
    ready we want to return SAS_PHY_DOWN. But current indentation makes it
    look like we only do so in the else branch of if (mvi_dev).

    Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
    Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/scsi/mvsas/mv_sas.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/drivers/scsi/mvsas/mv_sas.c
    +++ b/drivers/scsi/mvsas/mv_sas.c
    @@ -737,8 +737,8 @@ static int mvs_task_prep(struct sas_task
    mv_dprintk("device %016llx not ready.\n",
    SAS_ADDR(dev->sas_addr));

    - rc = SAS_PHY_DOWN;
    - return rc;
    + rc = SAS_PHY_DOWN;
    + return rc;
    }
    tei.port = dev->port->lldd_port;
    if (tei.port && !tei.port->port_attached && !tmf) {
    \
     
     \ /
      Last update: 2017-11-08 20:59    [W:2.148 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site