lkml.org 
[lkml]   [2017]   [Nov]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 063/294] powerpc/pseries: Fix of_node_put() underflow during reconfig remove
    3.16.50-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Laurent Vivier <lvivier@redhat.com>

    commit 4fd1bd443e80b12f0a01a45fb9a793206b41cb72 upstream.

    As for commit 68baf692c435 ("powerpc/pseries: Fix of_node_put()
    underflow during DLPAR remove"), the call to of_node_put() must be
    removed from pSeries_reconfig_remove_node().

    dlpar_detach_node() and pSeries_reconfig_remove_node() both call
    of_detach_node(), and thus the node should not be released in both
    cases.

    Fixes: 0829f6d1f69e ("of: device_node kobject lifecycle fixes")
    Signed-off-by: Laurent Vivier <lvivier@redhat.com>
    Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
    Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    arch/powerpc/platforms/pseries/reconfig.c | 1 -
    1 file changed, 1 deletion(-)

    --- a/arch/powerpc/platforms/pseries/reconfig.c
    +++ b/arch/powerpc/platforms/pseries/reconfig.c
    @@ -112,7 +112,6 @@ static int pSeries_reconfig_remove_node(

    of_detach_node(np);
    of_node_put(parent);
    - of_node_put(np); /* Must decrement the refcount */
    return 0;
    }

    \
     
     \ /
      Last update: 2017-11-08 20:59    [W:4.054 / U:0.292 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site