lkml.org 
[lkml]   [2017]   [Nov]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 260/294] video: mx3fb: always enable BACKLIGHT_LCD_SUPPORT
    3.16.50-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Arnd Bergmann <arnd@arndb.de>

    commit 9c8ee3c7341393811d5be5eb61b815e76f92c799 upstream.

    Commit 7edaa761ee81b ("video: mx3fb: Add backlight control support")
    changed the mx3fb driver so it always selects the BACKLIGHT_CLASS_DEVICE
    symbol, but that is hidden behind BACKLIGHT_LCD_SUPPORT in Kconfig, so
    we get a Kconfig warning for multi_v5_defconfig, which doesn't have that:

    Warning: (DRM_RADEON && DRM_NOUVEAU && DRM_I915 && DRM_GMA500 &&
    DRM_SHMOBILE && DRM_TILCDC && FB_BACKLIGHT && FB_MX3 && USB_APPLEDISPLAY
    && FB_OLPC_DCON && ASUS_LAPTOP && SONY_LAPTOP && THINKPAD_ACPI &&
    EEEPC_LAPTOP && ACPI_CMPC && SAMSUNG_Q10) selects BACKLIGHT_CLASS_DEVICE
    which has unmet direct dependencies (HAS_IOMEM && BACKLIGHT_LCD_SUPPORT)

    This makes sure we always enable both symbols together for mx3fb, like
    we do for the other drivers that can't be built without backlight
    support. Note that a better solution would be to ensure the driver can
    work with or without backlight support.

    Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    Cc: Alexander Stein <alexander.stein@systec-electronic.com>
    Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
    Cc: linux-fbdev@vger.kernel.org
    Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
    Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/video/fbdev/Kconfig | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    --- a/drivers/video/fbdev/Kconfig
    +++ b/drivers/video/fbdev/Kconfig
    @@ -2330,10 +2330,11 @@ config FB_MSM
    config FB_MX3
    tristate "MX3 Framebuffer support"
    depends on FB && MX3_IPU
    + select BACKLIGHT_CLASS_DEVICE
    + select BACKLIGHT_LCD_SUPPORT
    select FB_CFB_FILLRECT
    select FB_CFB_COPYAREA
    select FB_CFB_IMAGEBLIT
    - select BACKLIGHT_CLASS_DEVICE
    default y
    help
    This is a framebuffer device for the i.MX31 LCD Controller. So
    \
     
     \ /
      Last update: 2017-11-08 20:58    [W:3.956 / U:1.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site