lkml.org 
[lkml]   [2017]   [Nov]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 138/294] net: systemport: Be drop monitor friendly
    3.16.50-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Florian Fainelli <f.fainelli@gmail.com>

    commit c45182eb967af11e9482168be5be41aa22e5d321 upstream.

    Utilize dev_consume_skb_any(cb->skb) in bcm_sysport_free_cb() which is
    used when a TX packet is completed, as well as when the RX ring is
    cleaned on shutdown. None of these two cases are packet drops, so be
    drop monitor friendly.

    Suggested-by: Eric Dumazet <edumazet@gmail.com>
    Fixes: 80105befdb4b ("net: systemport: add Broadcom SYSTEMPORT Ethernet MAC driver")
    Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/net/ethernet/broadcom/bcmsysport.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/net/ethernet/broadcom/bcmsysport.c
    +++ b/drivers/net/ethernet/broadcom/bcmsysport.c
    @@ -386,7 +386,7 @@ static void bcm_sysport_get_stats(struct

    static void bcm_sysport_free_cb(struct bcm_sysport_cb *cb)
    {
    - dev_kfree_skb_any(cb->skb);
    + dev_consume_skb_any(cb->skb);
    cb->skb = NULL;
    dma_unmap_addr_set(cb, dma_addr, 0);
    }
    \
     
     \ /
      Last update: 2017-11-08 20:58    [W:4.135 / U:0.992 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site