Messages in this thread Patch in this message | | | Date | Sun, 5 Nov 2017 13:19:02 +0100 | From | Johan Hovold <> | Subject | Re: [PATCH 1/2] staging: greybus: operation: add private data with get/set accessors |
| |
On Sun, Nov 05, 2017 at 03:27:38AM +0000, Bryan O'Donoghue wrote: > Asynchronous operation completion handler's lives are made easier if there > is a generic pointer that can store private data associated with the > operation. This patch adds a pointer field to operation.h and get/set
As I mentioned in my review of v3 (back in January), this should be s/operation.h/struct gb_operation/.
> methods to access that pointer. > > Signed-off-by: Bryan O'Donoghue <pure.logic@nexus-software.ie>
Reviewed-by: Johan Hovold <johan@kernel.org>
> --- a/drivers/staging/greybus/operation.h > +++ b/drivers/staging/greybus/operation.h > @@ -105,6 +105,8 @@ struct gb_operation { > > int active; > struct list_head links; /* connection->operations */ > + > + void *private; > };
Johan
| |