Messages in this thread | | | From | Andy Shevchenko <> | Date | Sun, 5 Nov 2017 14:31:57 +0200 | Subject | Re: [PATCH 0/4] platform/x86: intel-vbtn: Add support for several more switches/buttons |
| |
On Fri, Nov 3, 2017 at 9:03 PM, Stefan Brüns <stefan.bruens@rwth-aachen.de> wrote: > Currently, intel-vbtn only supports the most relevant buttons, although > there are several more events, mostly in use by convertibles. > > This series adds support for three more events. One of these events > is a switch (SW_*) event, which is currently not working when using > sparse keymaps. The first patch fixes this combination. > > The second patch adds support for the SW_TABLET_MODE switch, which > is used by current convertibles. > > The third patch adds support for the KEY_ROTATE_DISPLAY. On the Dell > XPS 12 (9Q33), rotation lock is implemented as a button to toggle > between locked and unlocked state. In locked state, the accelerometer > should be ignored, while in unlocked the screen contents should > autorotate based on the tablet orientation. The same functionality > is likely implemented as a switch (SW_ROTATE_LOCK event) on different > hardware. > > The fourth patch adds support for the "Windows logo" button/key found on > the XPS 12 display (i.e. in tablet mode, it is the only key reachable). > The Lenovo Helix 2 has an equivalent touch button. The event currently > uses KEY_MENU, although a distinct key code may be a better choice. >
All, except first, are applied to my review and testing queue, thanks!
> > Stefan Brüns (4): > Input: sparse-keymap - send sync event for KE_SW/KW_VSW > platform/x86: intel-vbtn: support SW_TABLET_MODE > platform/x86: intel-vbtn: support KEY_ROTATE_DISPLAY > platform/x86: intel-vbtn: support panel front button > > drivers/input/sparse-keymap.c | 1 + > drivers/platform/x86/intel-vbtn.c | 6 ++++++ > 2 files changed, 7 insertions(+) > > -- > 2.14.3 >
-- With Best Regards, Andy Shevchenko
| |