lkml.org 
[lkml]   [2017]   [Nov]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] scsi: require CAP_SYS_ADMIN to write to procfs interface
From
Date
On 11/04/2017 11:59 AM, Aleksa Sarai wrote:
> Previously, the only capability effectively required to operate on the
> /proc/scsi interface was CAP_DAC_OVERRIDE (or for some other files,
> having an fsuid of GLOBAL_ROOT_UID was enough). This means that
> semi-privileged processes could interfere with core components of a
> system (such as causing a DoS by removing the underlying SCSI device of
> the host's / mount).
>
> Cc: <stable@vger.kernel.org>
> Cc: "Eric W. Biederman" <ebiederm@xmission.com>
> Signed-off-by: Aleksa Sarai <asarai@suse.de>
> ---
> drivers/scsi/scsi_proc.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/scsi_proc.c b/drivers/scsi/scsi_proc.c
> index 480a597b3877..486aedce2f05 100644
> --- a/drivers/scsi/scsi_proc.c
> +++ b/drivers/scsi/scsi_proc.c
> @@ -51,7 +51,10 @@ static ssize_t proc_scsi_host_write(struct file *file, const char __user *buf,
> struct Scsi_Host *shost = PDE_DATA(file_inode(file));
> ssize_t ret = -ENOMEM;
> char *page;
> -
> +
> + if (!capable(CAP_SYS_ADMIN))
> + return -EPERM

did that build without a trailing ';' ?

> +
> if (count > PROC_BLOCK_SIZE)
> return -EOVERFLOW;
>
> @@ -313,6 +316,9 @@ static ssize_t proc_scsi_write(struct file *file, const char __user *buf,
> char *buffer, *p;
> int err;
>
> + if (!capable(CAP_SYS_ADMIN))
> + return -EPERM;
> +
> if (!buf || length > PAGE_SIZE)
> return -EINVAL;
>
>


--
~Randy

\
 
 \ /
  Last update: 2017-11-04 21:22    [W:0.122 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site