Messages in this thread | | | From | Philippe Ombredanne <> | Date | Thu, 30 Nov 2017 09:21:29 +0100 | Subject | Re: [patch v12 2/4] drivers: jtag: Add Aspeed SoC 24xx and 25xx families JTAG master driver |
| |
On Wed, Nov 29, 2017 at 11:51 PM, Kun Yi <kunyi@google.com> wrote: > On Tue, Nov 14, 2017 at 8:11 AM, Oleksandr Shamray > <oleksandrs@mellanox.com> wrote: [] >> diff --git a/drivers/jtag/jtag-aspeed.c b/drivers/jtag/jtag-aspeed.c >> new file mode 100644 >> index 0000000..a6e2417 >> --- /dev/null >> +++ b/drivers/jtag/jtag-aspeed.c >> @@ -0,0 +1,782 @@ >> +/* >> + * drivers/jtag/aspeed-jtag.c >> + * >> + * Copyright (c) 2017 Mellanox Technologies. All rights reserved. >> + * Copyright (c) 2017 Oleksandr Shamray <oleksandrs@mellanox.com> >> + * >> + * Released under the GPLv2 only. >> + * SPDX-License-Identifier: GPL-2.0 >> + */
I think the SPDX id should be on the first line as requested by Linus and documented by Thomas (tglx) and Greg (greg-kh). And it should use // comments, e.g:
// SPDX-License-Identifier: GPL-2.0
See the threads discussing all these.
-- Cordially Philippe Ombredanne
| |