lkml.org 
[lkml]   [2017]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3] cpufreq: schedutil: Examine the correct CPU when we update util
On 03-11-17, 13:36, Chris Redpath wrote:
> After
> 674e75411fc2 ("sched: cpufreq: Allow remote cpufreq callbacks")
>
> We stopped always reading utilization for the cpu we are running
> the governor on, and instead read it for the cpu which we've been
> told has updated utilization. This is stored in sugov_cpu->cpu.
>
> The value is set in sugov_register but we clear it in sugov_start
> which leads to always looking at the utilization of CPU0 instead
> of the correct one.
>
> Let's fix this by consolidating the initialization code into
> sugov_start().
>
> Fixes: 674e75411fc2 ("sched: cpufreq: Allow remote cpufreq callbacks")
> Signed-off-by: Chris Redpath <chris.redpath@arm.com>
> Reviewed-by: Patrick Bellasi <patrick.bellasi@arm.com>
> Reviewed-by: Brendan Jackman <brendan.jackman@arm.com>
> Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
> Cc: Viresh Kumar <viresh.kumar@linaro.org>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Peter Zijlstra <peterz@infradead.org>
> ---
> kernel/sched/cpufreq_schedutil.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

--
viresh

\
 
 \ /
  Last update: 2017-11-03 16:46    [W:0.054 / U:0.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site