Messages in this thread | | | Date | Fri, 3 Nov 2017 21:42:03 +0800 | From | Herbert Xu <> | Subject | Re: [PATCH 1/2] x86/crypto/sha256-mb: fix panic due to unaligned access |
| |
On Mon, Oct 16, 2017 at 06:51:30PM +0300, Andrey Ryabinin wrote: > struct sha256_ctx_mgr allocated in sha256_mb_mod_init() via kzalloc() > and later passed in sha256_mb_flusher_mgr_flush_avx2() function where > instructions vmovdqa used to access the struct. vmovdqa requires > 16-bytes aligned argument, but nothing guarantees that struct > sha256_ctx_mgr will have that alignment. Unaligned vmovdqa will > generate GP fault. > > Fix this by replacing vmovdqa with vmovdqu which doesn't have alignment > requirements. > > Fixes: a377c6b1876e ("crypto: sha256-mb - submit/flush routines for AVX2") > Reported-by: Josh Poimboeuf <jpoimboe@redhat.com> > Signed-off-by: Andrey Ryabinin <aryabinin@virtuozzo.com> > Cc: <stable@vger.kernel.org>
Both patches applied. Thanks. -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| |