Messages in this thread | | | From | Andy Shevchenko <> | Date | Fri, 3 Nov 2017 14:37:16 +0200 | Subject | Re: [PATCH] platform: x86: dell-smo8800: remove redundant assignments to byte_data |
| |
On Tue, Oct 31, 2017 at 8:41 PM, Pali Rohár <pali.rohar@gmail.com> wrote: > On Tuesday 31 October 2017 20:08:45 Andy Shevchenko wrote: >> On Tue, Oct 31, 2017 at 4:13 PM, Pali Rohár <pali.rohar@gmail.com> wrote: >> > On Tuesday 31 October 2017 16:07:25 Andy Shevchenko wrote: >> >> On Tue, Oct 31, 2017 at 3:55 PM, Pali Rohár <pali.rohar@gmail.com> wrote: >> >> > On Tuesday 31 October 2017 15:47:58 Andy Shevchenko wrote: >> >> >> On Tue, Oct 31, 2017 at 1:03 PM, Colin King <colin.king@canonical.com> wrote: >> >> >> OK, though it doesn't clarify the intention of the byte_data >> >> (useless?) assignments. >> > >> > Probably similar code pattern exists in that lis3lv* driver... >> >> So, it seems to me OK to apply the patch. No objections? > > No objections, you can add my: > > Acked-by: Pali Rohár <pali.rohar@gmail.com>
Applied to my review and testing queue, thanks!
> > -- > Pali Rohár > pali.rohar@gmail.com
-- With Best Regards, Andy Shevchenko
| |