Messages in this thread | | | Subject | Re: [PATCH] xen/pvcalls: fix unsigned less than zero error check | From | Juergen Gross <> | Date | Fri, 3 Nov 2017 10:01:16 +0100 |
| |
On 03/11/17 09:42, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > The check on bedata->ref is never true because ref is an unsigned > integer. Fix this by assigning signed int ret to the return of the > call to gnttab_claim_grant_reference so the -ve return can be checked. > > Detected by CoverityScan, CID#1460358 ("Unsigned compared against 0") > > Fixes: 219681909913 ("xen/pvcalls: connect to the backend") > Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Juergen
| |