lkml.org 
[lkml]   [2017]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 5/5] arm64: dts: rockchip: update mipi node for RK3399
+ Doug, since he was asking these things elsewhere

On Tue, Nov 28, 2017 at 07:20:06PM +0800, Nickey Yang wrote:
> This patch update mipi node for RK3399 DSI controller
> based on the Synopsys DesignWare MIPI DSI host controller.
>
> Signed-off-by: Nickey Yang <nickey.yang@rock-chips.com>
> ---
> arch/arm64/boot/dts/rockchip/rk3399.dtsi | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> index d340b58a..0ac67a9 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> @@ -1652,9 +1652,11 @@
> status = "disabled";
>
> ports {
> - mipi_in: port {
> - #address-cells = <1>;
> - #size-cells = <0>;
> + #address-cells = <1>;
> + #size-cells = <0>;

^^ It's good to add these here, since child nodes are going to have unit
addresses.

> +
> + mipi_in: port@0 {
> + reg = <0>;

^^ But you're removing the #{address,size}-cells from the port, while
still using unit addresses on its subnodes (the endpoint@... nodes). You
should keep *both*, since both the 'ports' node and the 'port@0' node
will have children with addresses.

Brian

>
> mipi_in_vopb: endpoint@0 {
> reg = <0>;
> --
> 1.9.1
>

\
 
 \ /
  Last update: 2017-11-29 19:37    [W:0.135 / U:7.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site