lkml.org 
[lkml]   [2017]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86/entry/64: Fix native_load_gs_index() SWAPGS handling with IRQ state tracing enabled
On Wed, Nov 29, 2017 at 09:57:43AM -0800, Andy Lutomirski wrote:
> On Tue, Nov 28, 2017 at 11:09 PM, Ingo Molnar <mingo@kernel.org> wrote:

> > On a related note, we should definitely extend the 'intended GS state' annotation
> > comments I did in this patch to all SWAPGS instances - this way code review has a
> > much higher chance of finding discrepancies between intent and actual code.
>
> Agreed. I'll send a patch.

Alternatively we could do something like:

SWITCH_TO_KERNEL_GS
SWITCH_TO_USER_GS

and have them do the SWAPGS with an (optional) assertion of the actual
GS.

\
 
 \ /
  Last update: 2017-11-29 19:09    [W:0.264 / U:0.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site