Messages in this thread | | | Date | Wed, 29 Nov 2017 09:10:50 -0600 | From | "Gustavo A. R. Silva" <> | Subject | Re: [PATCH] x86/syscalls: Mark expected switch fall-throughs |
| |
Quoting Thomas Gleixner <tglx@linutronix.de>:
> > So I have to ask WHY this information was not in the changelog of the patch > in question: > > 1) How it works > > 2) Why comments have been chosen over macros >
I will add this info and send the patch again.
>> In preparation to enabling -Wimplicit-fallthrough, mark switch cases >> where we are expecting to fall through. > > It's not a reviewers job to chase that information down. > > While I can understand that the comments are intentional due to existing > tools, I still prefer the macro/annotation. But I'm not religious about it > when there is common consensus. :) >
Awesome
Thanks, Thomas. -- Gustavo A. R. Silva
| |