Messages in this thread | | | From | Linus Walleij <> | Date | Wed, 29 Nov 2017 14:16:47 +0100 | Subject | Re: [PATCH] gpiolib: don't allow OPEN_DRAIN & OPEN_SOURCE flags simultaneously |
| |
On Wed, Nov 15, 2017 at 4:47 PM, Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> Do not allow OPEN_SOURCE & OPEN_DRAIN flags in a single request. If > the hardware actually supports enabling both at the same time the > electrical result would be disastrous. > > Suggested-by: Linus Walleij <linus.walleij@linaro.org> > Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl> > --- > There was a misunderstanding as to what the goal of my previous commit > 609aaf6a6029 ("gpiolib: don't allow OPEN_DRAIN & OPEN_SOURCE flags for > input") was, which resulted in discovering another thing that needs > fixing. This change was suggested to me by Linus earlier today.
Awesome, thanks.
Patch applied.
I wonder if we should even put some swear words into dmesg for this.
Yours, Linus Walleij
| |