lkml.org 
[lkml]   [2017]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [alsa-devel] [PATCH 1/5 v4] ASoC: ep93xx-ac97: Fix platform_get_irq's error checking
On Mon, Nov 20, 2017 at 09:31:40PM +0530, arvindY wrote:
> On Monday 20 November 2017 07:07 PM, Alexandre Belloni wrote:
> > On 19/11/2017 at 09:45:00 +0530, Arvind Yadav wrote:

> > To ensure this doesn't get applied: platform_get_irq can return
> > -EPROBE_DEFER and this must be handled properly.

> Yes, you are right. We should retry to get an irq for device. But ASoC
> driver is not retrying. if platfore_get_irq() fail here, Driver is throwing
> an error.
> and this patch is only to fix error checking which is not correct in Driver.

> > > irq = platform_get_irq(pdev, 0);
> > > - if (!irq)
> > > + if (irq <= 0)
> > > return -ENODEV;

This is just squashing all error codes into -ENODEV, we'd be handling
probe deferral properly if we just returned the raw error code here. We
need separate handling for irq == 0 which is an error but not an error
code and for cases where we've got an error code.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2017-11-29 11:53    [W:0.067 / U:7.920 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site