Messages in this thread | | | Subject | Re: [PATCH] i2c-cht-wc: constify platform_device_id | From | Hans de Goede <> | Date | Tue, 28 Nov 2017 14:25:29 +0100 |
| |
Hi,
On 28-11-17 11:25, Arvind Yadav wrote: > platform_device_id are not supposed to change at runtime. All functions > working with platform_device_id provided by <linux/platform_device.h> > work with const platform_device_id. So mark the non-const structs as > const. > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> --- > drivers/i2c/busses/i2c-cht-wc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/i2c/busses/i2c-cht-wc.c b/drivers/i2c/busses/i2c-cht-wc.c > index 190bbbc..db56759 100644 > --- a/drivers/i2c/busses/i2c-cht-wc.c > +++ b/drivers/i2c/busses/i2c-cht-wc.c > @@ -342,7 +342,7 @@ static int cht_wc_i2c_adap_i2c_remove(struct platform_device *pdev) > return 0; > } > > -static struct platform_device_id cht_wc_i2c_adap_id_table[] = { > +static const struct platform_device_id cht_wc_i2c_adap_id_table[] = { > { .name = "cht_wcove_ext_chgr" }, > {}, > }; >
| |