lkml.org 
[lkml]   [2017]   [Nov]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] staging: sm750b: Fix coding style issues in sm750_accel.c
On Sat, Nov 25, 2017 at 05:48:11PM -0500, Jeremy Lacomis wrote:
> This is a patch to sm750_accel.c that fixes 80-character line length
> warnings found by checkpatch.pl. It also fixes some grammatical errors
> in comments and moves parameter-specific comments from inline to before
> the function.
>
> Signed-off-by: Jeremy Lacomis <j.lacomis@gmail.com>
> ---
> Changes in v2:
> - Change function comments to the kernel-doc format
>
> drivers/staging/sm750fb/sm750_accel.c | 189 ++++++++++++++++++----------------
> 1 file changed, 103 insertions(+), 86 deletions(-)
>
> diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c
> index 1035e91e7cd3..42cd920111bf 100644
> --- a/drivers/staging/sm750fb/sm750_accel.c
> +++ b/drivers/staging/sm750fb/sm750_accel.c
> @@ -1,4 +1,4 @@
> -// SPDX-License-Identifier: GPL-2.0
> +/* SPDX-License-Identifier: GPL-2.0 */

Why did you change this line? That is not correct.

Only ever do one "logical" thing per patch. If you have to say "also"
in a changelog text, that's a huge hint you are doing something wrong.

thanks,

greg k-h

\
 
 \ /
  Last update: 2017-11-28 14:14    [W:0.050 / U:2.464 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site