lkml.org 
[lkml]   [2017]   [Nov]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/6] staging: pi433: pi433_if.c: fix space prohibited coding style issues
On Wed, Nov 15, 2017 at 04:35:51PM -0800, Chase Metzger wrote:
> Remove unnecessary spaces before and after parenthesis' to comply
> with the kernel coding style.
>
> Signed-off-by: Chase Metzger <chasemetzger15@gmail.com>
> ---
> drivers/staging/pi433/pi433_if.c | 34 +++++++++++++++++-----------------
> 1 file changed, 17 insertions(+), 17 deletions(-)
>
> diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
> index 3c5d8a05e976..ad89504655af 100644
> --- a/drivers/staging/pi433/pi433_if.c
> +++ b/drivers/staging/pi433/pi433_if.c
> @@ -342,7 +342,7 @@ pi433_receive(void *data)
> return retval;
>
> /* now check RSSI, if low wait for getting high (RSSI interrupt) */
> - while ( !rf69_get_flag(dev->spi, rssiExceededThreshold) ) {
> + while (!rf69_get_flag(dev->spi, rssiExceededThreshold)) {
> /* allow tx to interrupt us while waiting for high RSSI */
> dev->interrupt_rx_allowed = true;
> wake_up_interruptible(&dev->tx_wait_queue);
> @@ -413,7 +413,7 @@ pi433_receive(void *data)
>
> /* get payload */
> while (dev->rx_position < bytes_total) {
> - if ( !rf69_get_flag(dev->spi, payloadReady) ) {
> + if (!rf69_get_flag(dev->spi, payloadReady)) {
> retval = wait_event_interruptible(dev->fifo_wait_queue,
> dev->free_in_fifo < FIFO_SIZE);
> if (retval) /* wait was interrupted */
> @@ -473,9 +473,9 @@ pi433_tx_thread(void *data)
> /* wait for fifo to be populated or for request to terminate*/
> dev_dbg(device->dev, "thread: going to wait for new messages");
> wait_event_interruptible(device->tx_wait_queue,
> - ( !kfifo_is_empty(&device->tx_fifo) ||
> - kthread_should_stop() ));
> - if ( kthread_should_stop() )
> + (!kfifo_is_empty(&device->tx_fifo) ||
> + kthread_should_stop()));

Indent this properly too if you are touching it.

thanks,

greg k-h

\
 
 \ /
  Last update: 2017-11-28 14:12    [W:0.060 / U:6.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site