[lkml]   [2017]   [Nov]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v2 07/10] perf stat: Allocate shadow stats buffer for threads

On 11/28/2017 7:12 PM, Jiri Olsa wrote:
> On Mon, Nov 27, 2017 at 10:07:27PM +0800, Jin Yao wrote:
>> After perf_evlist__create_maps() being executed, we can get all
>> threads from /proc. And via thread_map__nr(), we can also get
>> the number of threads.
>> With the number of threads, the patch allocates a buffer which
>> will record the shadow stats for these threads.
>> The buffer pointer is saved in stat_config.
> why don't you add struct perf_stat_config::*stats|stats_num in this patch?
> I dont see any reason it's introduced earlier
> jirka

OK, let me check it.

Jin Yao

 \ /
  Last update: 2017-11-28 13:24    [W:0.055 / U:0.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site