lkml.org 
[lkml]   [2017]   [Nov]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 040/193] dm mpath: remove annoying message of blk_get_request() returned -11
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Ming Lei <ming.lei@redhat.com>

    commit 9dc112e2daf87b40607fd8d357e2d7de32290d45 upstream.

    It is very normal to see allocation failure, especially with blk-mq
    request_queues, so it's unnecessary to report this error and annoy
    people.

    In practice this 'blk_get_request() returned -11' error gets logged
    quite frequently when a blk-mq DM multipath device sees heavy IO.

    This change is marked for stable@ because the annoying message in
    question was included in stable@ commit 7083abbbf.

    Fixes: 7083abbbf ("dm mpath: avoid that path removal can trigger an infinite loop")
    Signed-off-by: Ming Lei <ming.lei@redhat.com>
    Signed-off-by: Mike Snitzer <snitzer@redhat.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/md/dm-mpath.c | 2 --
    1 file changed, 2 deletions(-)

    --- a/drivers/md/dm-mpath.c
    +++ b/drivers/md/dm-mpath.c
    @@ -499,8 +499,6 @@ static int multipath_clone_and_map(struc
    if (IS_ERR(clone)) {
    /* EBUSY, ENODEV or EWOULDBLOCK: requeue */
    bool queue_dying = blk_queue_dying(q);
    - DMERR_LIMIT("blk_get_request() returned %ld%s - requeuing",
    - PTR_ERR(clone), queue_dying ? " (path offline)" : "");
    if (queue_dying) {
    atomic_inc(&m->pg_init_in_progress);
    activate_or_offline_path(pgpath);

    \
     
     \ /
      Last update: 2017-11-28 12:32    [W:4.042 / U:0.604 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site