lkml.org 
[lkml]   [2017]   [Nov]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 4/6] ARM: dts: imx6qdl: Add Variscite DART-MX6 SoM support
From
Date
On 27/11/2017 13:57, Fabio Estevam wrote:
> On Mon, Nov 27, 2017 at 10:28 AM, Neil Armstrong
> <narmstrong@baylibre.com> wrote:
>
>> +&pcie {
>> + fsl,tx-swing-full = <103>;
>> + fsl,tx-swing-low = <103>;
>> + reset-gpio = <&gpio4 11 GPIO_ACTIVE_HIGH>;
>
> This can only be active high if 'reset-gpio-active-high' property is
> present, so what you
> want here is:
> reset-gpio = <&gpio4 11 GPIO_ACTIVE_LOW>;
>
> With this fixed:
>
> Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
>

Ok,

I will post a v4 lately with this fixed.

Thanks,
Neil

\
 
 \ /
  Last update: 2017-11-28 12:17    [W:0.037 / U:1.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site