Messages in this thread |  | | From | Arnd Bergmann <> | Date | Tue, 28 Nov 2017 10:23:50 +0100 | Subject | Re: [PATCH v2 14/35] nds32: System calls handling |
| |
On Tue, Nov 28, 2017 at 3:18 AM, Vincent Chen <deanbo422@gmail.com> wrote: > 2017-11-27 22:46 GMT+08:00 Arnd Bergmann <arnd@arndb.de>: >> On Mon, Nov 27, 2017 at 1:28 PM, Greentime Hu <green.hu@gmail.com> wrote:
>>> diff --git a/arch/nds32/include/uapi/asm/unistd.h b/arch/nds32/include/uapi/asm/unistd.h >>> new file mode 100644 >>> index 0000000..2bad1e7 >>> --- /dev/null >>> +++ b/arch/nds32/include/uapi/asm/unistd.h >> >>> + >>> +#define __ARCH_WANT_RENAMEAT >>> +#define __ARCH_WANT_SYSCALL_OFF_T >> >> These two should not be here. >> > > Thanks. > But, I don't know I should move these two macro to which file. > In asm-generic/unistd.h, these two are used to decide whether relative > syscall number is defined or not. > Therefore, I put these two macros here in order that these two > definitions are available in user space.
What I meant is that they should not be available to user space.
The C libraries implement the user space interfaces based on the replacement system calls, e.g. an application calling the glibc stat() function will end up in the sys_stat64() system call entry point, not the older sys_newstat().
Arnd
|  |