lkml.org 
[lkml]   [2017]   [Nov]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 06/12] perf, tools, probe: Support a quiet argument for debug info open
On Wed, Nov 29, 2017 at 12:14:00PM +0900, Masami Hiramatsu wrote:
> On Mon, 27 Nov 2017 16:23:15 -0800
> Andi Kleen <andi@firstfloor.org> wrote:
>
> > From: Andi Kleen <ak@linux.intel.com>
> >
> > Add a extra quiet argument to the debug info open / probe finder
> > code that allows perf script to make them quieter. Otherwise
> > we may end up with too many error messages when lots of
> > instructions fail debug info parsing.
>
> IMHO, this kind of simple suppress warning message would better
> be done with pr_* implementation (or its macro) since there
> maybe new message added or other function which has warning
> messages can be called in the future.

Do you really mean adding a special pr_ / global just for this case?

Seems less clean to me, but I can do it.

-Andi

\
 
 \ /
  Last update: 2017-11-29 04:43    [W:0.046 / U:13.612 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site