lkml.org 
[lkml]   [2017]   [Nov]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] mm/page_owner: Use PTR_ERR_OR_ZERO()
From
Date
On 11/28/2017 12:08 AM, Vasyl Gomonovych wrote:
> Fix ptr_ret.cocci warnings:
> mm/page_owner.c:639:1-3: WARNING: PTR_ERR_OR_ZERO can be used
>
> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
>
> Generated by: scripts/coccinelle/api/ptr_ret.cocci
>
> Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>

Acked-by: Vlastimil Babka <vbabka@suse.cz>

> ---
> mm/page_owner.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/mm/page_owner.c b/mm/page_owner.c
> index 4f44b95b9d1e..79ae586d1bce 100644
> --- a/mm/page_owner.c
> +++ b/mm/page_owner.c
> @@ -636,9 +636,7 @@ static int __init pageowner_init(void)
>
> dentry = debugfs_create_file("page_owner", S_IRUSR, NULL,
> NULL, &proc_page_owner_operations);
> - if (IS_ERR(dentry))
> - return PTR_ERR(dentry);
>
> - return 0;
> + return PTR_ERR_OR_ZERO(dentry);
> }
> late_initcall(pageowner_init)
>

\
 
 \ /
  Last update: 2017-11-28 09:23    [W:0.032 / U:0.884 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site