Messages in this thread | | | Date | Tue, 28 Nov 2017 13:05:51 -0800 | From | Christoph Hellwig <> | Subject | Re: [PATCH v6 09/11] fs/pipe.c: export create_pipe_files() and replace_fd() |
| |
On Tue, Nov 28, 2017 at 10:42:20PM +0200, Jarkko Sakkinen wrote: > On Tue, Nov 28, 2017 at 06:35:04AM -0800, Christoph Hellwig wrote: > > Repeated NAK - any interface that deals with raw file descriptor table > > entries has absolutely no business in a driver. > > > > Please fix your API already. > > Does it make a differnece if the code is moved to arch/x86, which could > potentially happen (see Darren's and tglx's comments on v5)? Then the > need for export will be gone.
Yes. You still shall not play nasty games with file descriptors.
| |