[lkml]   [2017]   [Nov]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v5 next 1/5] modules:capabilities: add request_module_cap()
On Tue, Nov 28, 2017 at 11:14 AM, Luis R. Rodriguez <> wrote:
> kmod is just a helper to poke userpsace to load a module, that's it.
> The old init_module() and newer finit_module() do the real handy work or
> module loading, and both currently only use may_init_module():
> static int may_init_module(void)
> {
> if (!capable(CAP_SYS_MODULE) || modules_disabled)
> return -EPERM;
> return 0;
> }
> This begs the question:
> o If userspace just tries to just use raw finit_module() do we want similar
> checks?
> Otherwise, correct me if I'm wrong this all seems pointless.

Hm? That's direct-loading, not auto-loading. This series is only about

We already have a global sysctl for blocking direct-loading (modules_disabled).

> If we want something similar I think we might need to be processing aliases and
> check for the aliases for their desired restrictions on finit_module(),

We don't need to handle aliases.


Kees Cook
Pixel Security

 \ /
  Last update: 2017-11-28 21:12    [W:0.159 / U:1.976 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site