Messages in this thread | | | Date | Tue, 28 Nov 2017 20:48:28 +0100 (CET) | From | Thomas Gleixner <> | Subject | Re: [PATCH] x86/syscalls: Mark expected switch fall-throughs |
| |
On Tue, 28 Nov 2017, Gustavo A. R. Silva wrote: > This is what we want to add: > > # Warn about missing switch break or fall-through comment. > KBUILD_CFLAGS += $(call cc-option,-Wimplicit-fallthrough)
Can this be made to ignore comments and only accept the proper annotation?
> > > I have no idea who came up with that brilliant idea of parsing comments in > > > the code. It's so simple to make this parser completely fail that it's not > > > even funny anymore. > > > > > I don't get why someone would want to do that to himself. :/
Well, it's not intentional.
You add any comment and the parser thinks its correct. Or you typo the thing and it fails to recognize.
Thanks,
tglx
| |