Messages in this thread | | | Subject | Re: [PATCH 05/11] trace-cmd: Rename trace_profile() to trace_profile_int() | From | Vladislav Valtchev <> | Date | Tue, 28 Nov 2017 21:00:57 +0200 |
| |
On Tue, 2017-11-28 at 12:05 -0500, Steven Rostedt wrote: > > Couple of things. > > 1) A change like this should always be directly before the patch that > requires it. This is patch 5, and it's not until patch 8 that this > change is required. Please keep them next to each other. This should > have been patch 7. > > 2) trace_profile_int() is confusing. I keep thinking it's doing > something with integers. Call it do_trace_profile(). >
Sure, no problem. Thanks for the review!
| |