lkml.org 
[lkml]   [2017]   [Nov]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] tipc: call tipc_rcv() only if bearer is up in tipc_udp_recv()
From
Date
On 28.11.2017 16:58, David Miller wrote:
> From: Tommi Rantala <tommi.t.rantala@nokia.com>
> Date: Tue, 28 Nov 2017 14:53:15 +0200
>
>> -
>> - if (unlikely(msg_user(hdr) == LINK_CONFIG)) {
>> - err = tipc_udp_rcast_disc(b, skb);
>> - if (err)
>> - goto rcu_out;
>> + } else {
>> + if (unlikely(b && msg_user(hdr) == LINK_CONFIG))
>> + tipc_udp_rcast_disc(b, skb);
>> + kfree_skb(skb);
>> }
>
> Either put the 'err' propagation back or clearly explain in your
> commit log message why this part of the change if absolutely essential
> for this bug fix.
>
> Thank you.
>

Thanks for the feedback. I'll post patch v2 soon.

-Tommi

\
 
 \ /
  Last update: 2017-11-28 19:17    [W:0.051 / U:1.988 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site