lkml.org 
[lkml]   [2017]   [Nov]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 4/4] DTS: Pandora: fix panel compatibility string
From
Date
Hi Tony,

> Am 28.11.2017 um 17:04 schrieb Tony Lindgren <tony@atomide.com>:
>
> * H. Nikolaus Schaller <hns@goldelico.com> [171128 15:52]:
>> We can remove the unnecessary "omapdss," prefix because
>> the omapdrm driver takes care of it when matching with
>> the driver table.
>
> So is this needed as a fix or is this another clean-up?
>
> So is this is really needed as a fix?

Hm. How do you differentiate between "fix" and "cleanup"?
Maybe it is more a wording than a content issue...

For me it is a "fix" because it is semantically wrong to have
a prefix where it is not needed. And "fixing" it changes the
compiler output by 8 bytes.

"Cleanup" would be for me removing whitespace or empty lines
or typos in comments.

>
> If this is just clean-up, again, please resend once the driver
> changes have cleared.

There is no change to the pandora driver involved here. The Pandora
panel driver is already correct. Just the DTS has some redundant
content which should be removed.

So there is no dependency for this patch.

BR,
Nikolaus

>
> Regards,
>
> Tony
>
>> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
>> ---
>> arch/arm/boot/dts/omap3-pandora-common.dtsi | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/omap3-pandora-common.dtsi b/arch/arm/boot/dts/omap3-pandora-common.dtsi
>> index 53e007abdc71..64d967ec8c58 100644
>> --- a/arch/arm/boot/dts/omap3-pandora-common.dtsi
>> +++ b/arch/arm/boot/dts/omap3-pandora-common.dtsi
>> @@ -626,7 +626,7 @@
>>
>> lcd: lcd@1 {
>> reg = <1>; /* CS1 */
>> - compatible = "omapdss,tpo,td043mtea1";
>> + compatible = "tpo,td043mtea1";
>> spi-max-frequency = <100000>;
>> spi-cpol;
>> spi-cpha;
>> --
>> 2.12.2
>>

\
 
 \ /
  Last update: 2017-11-28 17:16    [W:0.060 / U:10.164 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site