lkml.org 
[lkml]   [2017]   [Nov]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 2/4] DTS: GTA04: fix panel compatibility string
From
Date

> Am 28.11.2017 um 17:00 schrieb Tony Lindgren <tony@atomide.com>:
>
> * H. Nikolaus Schaller <hns@goldelico.com> [171128 15:51]:
>>> Am 28.11.2017 um 16:10 schrieb Tony Lindgren <tony@atomide.com>:
>>> OK fine dropping both. Please update the description in both dts
>>> patches to make it clear they are needed as a fix. Preferrably
>>> with a proper fixes tag.
>>
>> Well, it is not "needed" in a strong sense since current mainline&stable
>> works. It is more a style and consistency fix to use "tpo," everywhere.
>>
>>>
>>> Having "We can remove the "omapdss," prefix" in the description sure
>>> does not sounds like it's needed as a fix :)
>>
>> The description has been improved on -v3.
>
> Thanks.
>
>>> Sounds like maybe these two should be just a single patch for
>>> a proper fix?
>>
>> Hm. I usually get the feedback to separate DT and driver fixes into
>> separate commits... Therefore I submit patch sets in the hope they
>> are not picked apart :)
>
> See "both dts patches" part above. Yes the dts patches can and should
> be sent separately. In almost every case if the dts patches cannot be
> applied separately it means your driver changes are breaking things.

That is why the v3 driver now accepts both, the old and the new vendor
name. This means applying the driver alone is safe. Applying or not
applying DTS patch afterwards is also safe.

BR,
Nikolaus

\
 
 \ /
  Last update: 2017-11-28 17:06    [W:0.045 / U:1.936 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site