lkml.org 
[lkml]   [2017]   [Nov]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] misc: vexpress: Use PTR_ERR_OR_ZERO()
On Tue, Nov 28, 2017 at 04:20:43PM +0100, Vasyl Gomonovych wrote:
> Fix ptr_ret.cocci warnings:
> drivers/misc/vexpress-syscfg.c:273:1-3: WARNING: PTR_ERR_OR_ZERO can be used
>
> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
>
> Generated by: scripts/coccinelle/api/ptr_ret.cocci
>
> Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>

Acked-by: Liviu Dudau <liviu.dudau@arm.com>

> ---
> drivers/misc/vexpress-syscfg.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/misc/vexpress-syscfg.c b/drivers/misc/vexpress-syscfg.c
> index 2cde80c7bb93..9eea30f54fd6 100644
> --- a/drivers/misc/vexpress-syscfg.c
> +++ b/drivers/misc/vexpress-syscfg.c
> @@ -270,10 +270,8 @@ static int vexpress_syscfg_probe(struct platform_device *pdev)
> /* Must use dev.parent (MFD), as that's where DT phandle points at... */
> bridge = vexpress_config_bridge_register(pdev->dev.parent,
> &vexpress_syscfg_bridge_ops, syscfg);
> - if (IS_ERR(bridge))
> - return PTR_ERR(bridge);
>
> - return 0;
> + return PTR_ERR_OR_ZERO(bridge);
> }
>
> static const struct platform_device_id vexpress_syscfg_id_table[] = {
> --
> 1.9.1
>

--
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯

\
 
 \ /
  Last update: 2017-11-28 16:55    [W:0.028 / U:5.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site