Messages in this thread | | | Date | Tue, 28 Nov 2017 07:10:39 -0800 | From | Tony Lindgren <> | Subject | Re: [PATCH v2 2/4] DTS: GTA04: fix panel compatibility string |
| |
* H. Nikolaus Schaller <hns@goldelico.com> [171128 15:04]: > Hi Tony, > > > Am 28.11.2017 um 15:57 schrieb Tony Lindgren <tony@atomide.com>: > > > > * H. Nikolaus Schaller <hns@goldelico.com> [171116 08:53]: > >> Vendor string is "tpo" and not "toppoly". > >> > >> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com> > >> --- > >> arch/arm/boot/dts/omap3-gta04.dtsi | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/arch/arm/boot/dts/omap3-gta04.dtsi b/arch/arm/boot/dts/omap3-gta04.dtsi > >> index 4504908c23fe..ec27ed67a22a 100644 > >> --- a/arch/arm/boot/dts/omap3-gta04.dtsi > >> +++ b/arch/arm/boot/dts/omap3-gta04.dtsi > >> @@ -86,7 +86,7 @@ > >> > >> /* lcd panel */ > >> lcd: td028ttec1@0 { > >> - compatible = "toppoly,td028ttec1"; > >> + compatible = "tpo,td028ttec1"; > >> reg = <0>; > >> spi-max-frequency = <100000>; > >> spi-cpol; > > > > Applying into omap-for-v4.15/fixes thanks. The other dts patch seems > > like it can wait for v4.16 merge window. > > Hm. Not really. It needs the panel driver to match. So either both or > none should be applied or it will break the panel from working. > > I am just 1-2 hours away from submitting a -v3 (rebased and tested > on top of 4.15-rc1).
OK fine dropping both. Please update the description in both dts patches to make it clear they are needed as a fix. Preferrably with a proper fixes tag.
Having "We can remove the "omapdss," prefix" in the description sure does not sounds like it's needed as a fix :)
Sounds like maybe these two should be just a single patch for a proper fix?
Regards,
Tony
| |